Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB) Disable trash/disabled/old/deprecated/unbalanced items #98

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(DB) Disable trash/disabled/old/deprecated/unbalanced items #98

merged 2 commits into from
Aug 26, 2024

Conversation

YggdrasilWotLK
Copy link

Changes Proposed:

  • Filter out wildly unbalanced items replacing almost all the seeding in certain categories (mostly engineering gadgets)
  • Disable all items with names old, deprecated, tomes and other spell books no longer used in WotLK, NPC equipment, "seasonal fish" items, etc.

Issues Addressed:

SOURCE:

Tests Performed:

  • Builds fine, tested in game

How to Test the Changes:

  1. Import SQL query
  2. Re-seed AH
  3. The trash/disabled/QA/etc. items are now virtually gone

@Helias
Copy link
Member

Helias commented Aug 24, 2024

the build is failing, not usre if it depends on your PR

@YggdrasilWotLK
Copy link
Author

I'd assume it's the order in which the SQL files are loaded? My PR has a SQL script inserting rows into the table for disabled items but it's running before the table is constructed by mod_auctionhousebot.sql. Is there a particular naming scheme I ought to follow for PRs in this repo or just any name alphabetically after mod_auctionhousebot.sql?

@Helias
Copy link
Member

Helias commented Aug 24, 2024

I'd assume it's the order in which the SQL files are loaded? My PR has a SQL script inserting rows into the table for disabled items but it's running before the table is constructed by mod_auctionhousebot.sql. Is there a particular naming scheme I ought to follow for PRs in this repo or just any name alphabetically after mod_auctionhousebot.sql?

I guess is alphabetical, try to rename it z_filter...

@Helias
Copy link
Member

Helias commented Aug 25, 2024

now it seems working, so the problem is the name and considering the alphabetical order, if you want to keep the current file name I can merge the PR, otherwise you could find a better name for it

@YggdrasilWotLK
Copy link
Author

The name is perfectly fine as is!

@Helias Helias merged commit 450239c into azerothcore:master Aug 26, 2024
1 check passed
@Helias
Copy link
Member

Helias commented Aug 26, 2024

ok, merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [PARTIAL FIX INCLUDED] Deprecated Items in Default Settings
2 participants