Add validation to MG scoped deployment stack New/Set cmdlets. (Azure#…

…25351) * Add validation to MG scoped deployment stack New/Set cmdlets. * Update ChangeLog.md --------- Co-authored-by: NoriZC <110961157+NoriZC@users.noreply.github.com>
azure-sdk · Jun 24, 2024 · 231a2c5 · 231a2c5
1 parent 98fe50d
commit 231a2c5
Show file tree

Hide file tree

Showing 14 changed files with 12,252 additions and 264,147 deletions.
diff --git a/src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs b/src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs
@@ -634,8 +634,7 @@ bool bypassStackOutOfSyncError
                 bypassStackOutOfSyncError
                 );
 
-            // TODO: Enable validation of MG scoped stacks before Create.
-            // ValidateDeploymentStack(deploymentStackModel, deploymentStackName, DeploymentStackScope.ManagementGroup, managementGroupId);
+            ValidateDeploymentStack(deploymentStackModel, deploymentStackName, DeploymentStackScope.ManagementGroup, managementGroupId);
 
             var deploymentStack = DeploymentStacksClient.DeploymentStacks.BeginCreateOrUpdateAtManagementGroup(managementGroupId,
                 deploymentStackName, deploymentStackModel);

diff --git a/...ources.Test.ScenarioTests.DeploymentStackTests/TestGetManagementGroupDeploymentStack.json b/...ources.Test.ScenarioTests.DeploymentStackTests/TestGetManagementGroupDeploymentStack.json
diff --git a/...loymentStackTests/TestNewAndSetAndSaveManagementGroupDeploymentStackWithTemplateSpec.json b/...loymentStackTests/TestNewAndSetAndSaveManagementGroupDeploymentStackWithTemplateSpec.json
diff --git a/...ioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackDenySettings.json b/...ioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackDenySettings.json
diff --git a/...narioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackWithBicep.json b/...narioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackWithBicep.json
diff --git a/...enarioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackWithTags.json b/...enarioTests.DeploymentStackTests/TestNewAndSetManagementGroupDeploymentStackWithTags.json
diff --git a/...ources.Test.ScenarioTests.DeploymentStackTests/TestNewManagementGroupDeploymentStack.json b/...ources.Test.ScenarioTests.DeploymentStackTests/TestNewManagementGroupDeploymentStack.json
diff --git a/...narioTests.DeploymentStackTests/TestNewManagementGroupDeploymentStackUnmanageActions.json b/...narioTests.DeploymentStackTests/TestNewManagementGroupDeploymentStackUnmanageActions.json
diff --git a/...ces.Test.ScenarioTests.DeploymentStackTests/TestRemoveManagementGroupDeploymentStack.json b/...ces.Test.ScenarioTests.DeploymentStackTests/TestRemoveManagementGroupDeploymentStack.json
diff --git a/...DeploymentStackTests/TestSaveAndRemoveManagementGroupDeploymentStackWithPipeOperator.json b/...DeploymentStackTests/TestSaveAndRemoveManagementGroupDeploymentStackWithPipeOperator.json
diff --git a/...st.ScenarioTests.DeploymentStackTests/TestSaveManagementGroupDeploymentStackTemplate.json b/...st.ScenarioTests.DeploymentStackTests/TestSaveManagementGroupDeploymentStackTemplate.json
diff --git a/...ources.Test.ScenarioTests.DeploymentStackTests/TestSetManagementGroupDeploymentStack.json b/...ources.Test.ScenarioTests.DeploymentStackTests/TestSetManagementGroupDeploymentStack.json
diff --git a/...narioTests.DeploymentStackTests/TestSetManagementGroupDeploymentStackUnmanageActions.json b/...narioTests.DeploymentStackTests/TestSetManagementGroupDeploymentStackUnmanageActions.json
diff --git a/src/Resources/Resources/ChangeLog.md b/src/Resources/Resources/ChangeLog.md
@@ -19,6 +19,7 @@
 -->
 
 ## Upcoming Release
+* Introduced validation of MG scoped deployment stack during New/Set cmdlet execution.
 * Updated Remove/New stack cmdlets with warnings for management groups ActionOnUnmanage and removed DeleteResourcesAndResourceGroups as valid ActionOnUnmanage value.
 * Supported get and assign versioned policy definitions and sets
 * Fixed syntax incompatible with windows powershell [#24971]