Remove status code 206 from retriable (Azure#38647)

azure-sdk · Nov 23, 2024 · 4f9b66a · 4f9b66a
1 parent 61d6697
commit 4f9b66a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md b/sdk/monitor/azure-monitor-opentelemetry-exporter/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 - Detect live metrics usage during runtime in addition to on startup
   ([#37694](https://github.com/Azure/azure-sdk-for-python/pull/37694))
+- Remove status code `206` from retry code + only count batch level for statsbeat
+  ([#38647](https://github.com/Azure/azure-sdk-for-python/pull/38647))
 
 ### Other Changes
 

diff --git a/...r/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py b/...r/azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/_constants.py
@@ -31,7 +31,6 @@
 )
 
 _RETRYABLE_STATUS_CODES = (
-    206,  # Partial success
     401,  # Unauthorized
     403,  # Forbidden
     408,  # Request Timeout

diff --git a/...azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py b/...azure-monitor-opentelemetry-exporter/azure/monitor/opentelemetry/exporter/export/_base.py
@@ -220,8 +220,6 @@ def _transmit(self, envelopes: List[TelemetryItem]) -> ExportResult:
                     for error in track_response.errors:
                         if _is_retryable_code(error.status_code):
                             resend_envelopes.append(envelopes[error.index])  # type: ignore
-                            if self._should_collect_stats():
-                                _update_requests_map(_REQ_RETRY_NAME[1], value=error.status_code)
                         else:
                             if not self._is_stats_exporter():
                                 logger.error(

diff --git a/sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_exporter.py b/sdk/monitor/azure-monitor-opentelemetry-exporter/tests/test_base_exporter.py
@@ -641,8 +641,9 @@ def test_statsbeat_206_retry(self, stats_mock):
             )
             result = exporter._transmit(custom_envelopes_to_export)
         stats_mock.assert_called_once()
-        self.assertEqual(len(_REQUESTS_MAP), 3)
-        self.assertEqual(_REQUESTS_MAP[_REQ_RETRY_NAME[1]][500], 1)
+        # We do not record any network statsbeat for 206 status code
+        self.assertEqual(len(_REQUESTS_MAP), 2)
+        self.assertIsNone(_REQUESTS_MAP.get('retry'))
         self.assertEqual(_REQUESTS_MAP["count"], 1)
         self.assertIsNotNone(_REQUESTS_MAP[_REQ_DURATION_NAME[1]])
         self.assertEqual(result, ExportResult.FAILED_NOT_RETRYABLE)