Skip to content

Commit

Permalink
[TASK] Use newly introduced extension selection and cleanup old code
Browse files Browse the repository at this point in the history
  • Loading branch information
ochorocho committed May 26, 2022
1 parent cf17b3f commit 1d9a779
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 130 deletions.
11 changes: 2 additions & 9 deletions Classes/Command/AcceptanceTestsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Symfony\Component\Filesystem\Exception\IOException;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Finder\Finder;
Expand All @@ -32,11 +31,6 @@ class AcceptanceTestsCommand extends AbstractCommand
*/
protected $filesystem;

/**
* @var SymfonyStyle $io
*/
protected $io;

/**
* @var PackageInterface $package
*/
Expand All @@ -54,8 +48,7 @@ protected function configure(): void
*/
protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->io = new SymfonyStyle($input, $output);
$this->package = $this->askForPackage($this->io);
$this->package = $this->packageResolver->resolvePackage($this->askForExtensionKey());

$packageKey = $this->package->getPackageKey();
$targetPackagePath = $this->package->getPackagePath();
Expand All @@ -70,7 +63,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
$finder = GeneralUtility::makeInstance(Finder::class);

$codeTemplatePath = '/Resources/Private/CodeTemplates/AcceptanceTests';
$templatePath = $this->getPackageResolver()->resolvePackage('b13/make')->getPackagePath() . $codeTemplatePath;
$templatePath = $this->packageResolver->resolvePackage('b13/make')->getPackagePath() . $codeTemplatePath;

$this->filesystem->mkdir([
$targetPackagePath . '/Tests/Acceptance/Fixtures',
Expand Down
114 changes: 0 additions & 114 deletions Classes/Command/RunTestsCommand.php

This file was deleted.

7 changes: 0 additions & 7 deletions Configuration/Services.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,3 @@ services:
command: 'make:acceptance'
description: 'Create files required to run acceptance tests'
schedulable: false

B13\Make\Command\RunTestsCommand:
tags:
- name: 'console.command'
command: 'make:runtests'
description: 'Setup runTests.sh to run tests, linter, cgl in a Docker environment'
schedulable: false

0 comments on commit 1d9a779

Please sign in to comment.