Merge pull request #21 from babbel/default-tags

Breaking change: Rename `var.tags` to `var.default_tags`
babbel · Sep 23, 2024 · 92d5536 · 92d5536
2 parents 1b9ea13 + df235d6
commit 92d5536
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 15 deletions.
diff --git a/README.md b/README.md
@@ -24,9 +24,5 @@ module "ses-sending-domain-example" {
   domain_name    = "example.com"
   route53_zone   = aws_route53_zone.email-example
   sns_topic_name = "example"
-
-  tags = {
-    environment = "production"
-  }
 }
 ```
diff --git a/_test/main.tf b/_test/main.tf
@@ -10,5 +10,9 @@ module "ses-sending-domain" {
     zone_id = "123"
   }
   sns_topic_name = "foo"
-  tags           = {}
+
+  default_tags = {
+    app = "example"
+    env = "test"
+  }
 }
diff --git a/notifications.tf b/notifications.tf
@@ -1,6 +1,6 @@
 resource "aws_sns_topic" "this" {
   name = var.sns_topic_name
-  tags = var.tags
+  tags = var.default_tags
 }
 
 resource "aws_ses_identity_notification_topic" "bounce" {

diff --git a/variables.tf b/variables.tf
@@ -1,3 +1,12 @@
+variable "default_tags" {
+  type    = map(string)
+  default = {}
+
+  description = <<EOS
+Map of tags assigned to all AWS resources created by this module.
+EOS
+}
+
 variable "domain_name" {
   type = string
 
@@ -25,12 +34,3 @@ variable "sns_topic_name" {
 Name of SNS topic.
 EOS
 }
-
-variable "tags" {
-  type    = map(string)
-  default = {}
-
-  description = <<EOS
-Map of tags assigned to all AWS resources created by this module.
-EOS
-}