New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

never link to branches; update $platformPackageRegexp from 1.8.5 #11

Open

glensc wants to merge 1 commit into balbuf:master from glensc:cs

Contributor

glensc commented Apr 15, 2019 •

edited

Loading

my standard disclaimer:

Don't link to branches!

see https://news.ycombinator.com/item?id=8046710
and https://help.github.com/articles/getting-permanent-links-to-files/
hit y
and perhaps https://github.com/josephfrazier/octopermalinker


          never link to branches; update $platformPackageRegexp from 1.8.5

9bc8fd4

Contributor Author

glensc commented May 9, 2020

Owner

balbuf commented Jun 22, 2020

@glensc looks like the regex was updated again, want to update this PR accordingly?

composer/composer@0ab48a1#diff-577304d6b2175e0b5c3fe90ff0a78239R31

Owner

balbuf commented Jun 22, 2020

This is part of 2.0.0-alpha, but at first blush I can't imagine there would be any BC issues. Thoughts?

Contributor Author

glensc commented Jun 25, 2020

you should merge this as is. I'm not interested at this time to investigate more about the impact of updating it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet