Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump airplay2 version #668

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

bump airplay2 version #668

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58d507f
bump airplay2 version
fabienheureux Sep 2, 2024
1ed7804
Fix failing build
fabienheureux Oct 26, 2024
3c45030
Fix build failing
fabienheureux Oct 26, 2024
108926d
Prevent split too much steps
fabienheureux Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/airplay/Dockerfile.template
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mikebrady/shairport-sync:4.1.1 as shairport
FROM mikebrady/shairport-sync:4.3.4 as shairport
WORKDIR /usr/src

ENV DBUS_SYSTEM_BUS_ADDRESS=unix:path=/host/run/dbus/system_bus_socket
Expand All @@ -8,9 +8,9 @@ SHELL ["/bin/sh", "-eo", "pipefail", "-c"]

# shairport-sync docker image doesn't include pulseaudio support so we use ALSA bridge
ENV PULSE_SERVER=tcp:localhost:4317
RUN apk update && apk add --no-cache supervisor curl~=7 && \
curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh \
&& apk del curl
RUN apk upgrade --no-cache && apk add --no-cache supervisor curl
RUN curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh
RUN apk del curl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
RUN apk upgrade --no-cache && apk add --no-cache supervisor curl
RUN curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh
RUN apk del curl
RUN apk upgrade --no-cache && apk add --no-cache supervisor curl && \
curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh \
apk del curl

Any reason why these steps can't happen together?

Copy link
Contributor Author

@fabienheureux fabienheureux Oct 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of the exact reason, but I had issues with building the airplay container without splitting these steps.
It was mostly trial and error...

I tried again with your suggestion and got the error below

Error: The command '/bin/sh -eo pipefail -c apk upgrade --no-cache && apk add --no-cache supervisor curl &&     curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh     apk del curl' returned a non-zero code: 85

I tried again with

RUN apk upgrade --no-cache
RUN apk add --no-cache supervisor curl && \
    curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh \
    apk del curl

And got the error below

[Error]             Some services failed to build:
[Error]               Service: airplay
[Error]                 Error: The command '/bin/sh -eo pipefail -c apk add --no-cache supervisor curl &&     curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh     apk del curl' returned a non-zero code: 2

Finally I tried with :

RUN apk upgrade --no-cache && apk add --no-cache supervisor curl && \
    curl -skL https://raw.githubusercontent.com/balena-io-experimental/audio/master/scripts/alsa-bridge/alpine-setup.sh | sh
RUN apk del curl

And this worked...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the branch

COPY start.sh /usr/src/
COPY supervisor.conf /usr/src/supervisor.conf
Expand Down
Loading