Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dmt and dsta rules #2970

Merged
merged 3 commits into from
Jan 21, 2025
Merged

fix: dmt and dsta rules #2970

merged 3 commits into from
Jan 21, 2025

Conversation

liorzam
Copy link
Collaborator

@liorzam liorzam commented Jan 18, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced validation for date format in alert execution details
    • Improved array handling in data analytics and investigation services
  • Refactor

    • Updated method signatures in data investigation service
    • Replaced direct array length checks with isEmpty function from lodash
    • Refined optional parameter handling in transaction-related methods
  • Bug Fixes

    • Improved robustness of array and parameter checks in transaction processing methods

Copy link

changeset-bot bot commented Jan 18, 2025

⚠️ No Changeset found

Latest commit: 76a37f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jan 18, 2025

Walkthrough

This pull request introduces changes across multiple services in the workflows service, primarily focusing on refactoring array and parameter handling. The modifications involve using Lodash's isEmpty function to check array emptiness in data analytics and investigation services. Additionally, a new constant for ISO date pattern validation is added to an integration test file, enhancing test coverage for alert execution details.

Changes

File Change Summary
services/workflows-service/src/alert/alert.service.intg.test.ts Added isoPattern constant for ISO 8601 date-time string validation
services/workflows-service/src/data-analytics/data-analytics.service.ts Replaced array length checks with lodash.isEmpty() in multiple methods
services/workflows-service/src/data-analytics/data-investigation.service.ts Updated method signatures, imported isEmpty, refined parameter handling using isEmpty()

Sequence Diagram

sequenceDiagram
    participant Service as DataAnalyticsService
    participant Lodash as Lodash Utility
    participant Method as Investigation Method

    Service->>Lodash: Check array emptiness
    Lodash-->>Service: Return emptiness status
    Service->>Method: Apply filters conditionally
    Method-->>Service: Process transaction data
Loading

Possibly related PRs

Suggested reviewers

  • MatanYadaev
  • tomer-shvadron
  • alonp99

Poem

🐰 In the realm of code so bright,
Where isEmpty checks take flight,
Refactoring with Lodash's might,
Our services now dance just right!
A rabbit's tale of clean delight! 🔍

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
services/workflows-service/src/data-analytics/data-investigation.service.ts (1)

281-307: Consider grouping related parameters together.

The parameter organization could be improved by grouping related parameters. For example:

const {
  projectId,
+ // Transaction filters
  direction,
  transactionType,
  paymentMethods,
  excludePaymentMethods,
+ // Rule parameters
  ruleType,
  amountThreshold,
} = options;

Otherwise, the changes look good with proper array validation using isEmpty.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 28bf7b9 and d13f6c2.

📒 Files selected for processing (3)
  • services/workflows-service/src/alert/alert.service.intg.test.ts (2 hunks)
  • services/workflows-service/src/data-analytics/data-analytics.service.ts (3 hunks)
  • services/workflows-service/src/data-analytics/data-investigation.service.ts (6 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: test_windows
  • GitHub Check: test_linux
  • GitHub Check: build (windows-latest)
  • GitHub Check: lint
  • GitHub Check: build (ubuntu-latest)
🔇 Additional comments (8)
services/workflows-service/src/data-analytics/data-investigation.service.ts (3)

20-20: LGTM!

The import of isEmpty from lodash is correctly placed.


171-186: LGTM! Improved array emptiness checks.

The use of isEmpty enhances the robustness of array validation for both transactionType and paymentMethods.


212-212: LGTM! Consistent parameter handling.

The removal of default values and use of isEmpty aligns with the changes in other methods.

Also applies to: 223-229

services/workflows-service/src/data-analytics/data-analytics.service.ts (3)

Line range hint 292-299: LGTM! Consistent array validation.

The use of isEmpty aligns with the changes in the investigation service.


490-492: LGTM! Consistent array validation.

The use of isEmpty maintains consistency with other methods.


Line range hint 816-824: LGTM! Consistent array validation.

The use of isEmpty follows the established pattern.

services/workflows-service/src/alert/alert.service.intg.test.ts (2)

85-86: LGTM! Valid ISO 8601 pattern.

The regex pattern correctly validates ISO 8601 date-time strings.


2403-2418: LGTM! Comprehensive test assertions.

The test properly validates the structure of executionDetails including the ISO date format.

@alonp99 alonp99 merged commit 5f128bb into dev Jan 21, 2025
18 checks passed
@alonp99 alonp99 deleted the bal-3404-alerts-with-no-transactions branch January 21, 2025 10:30
Omri-Levy added a commit that referenced this pull request Jan 21, 2025
* feat: updated styles for link elements (#2959)

* feat: added csv document rendering (#2958)

* fix(monitoring): changes the block ordering in website credibility view (#2963)

* feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960)

* feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961)

* refactor(websiteCredibility): fix CardContent height for no data (#2966)

* refactor(websiteCredibility): fix CardContent height for no data

- Remove unused Tooltip import from recharts
- Update CardContent class to ensure full height

(your code is like a tidy room: looks clean but still has hidden messes)

* empty

* fix: UI fixes for statistics and merchant monitoring report pages (#2965)

* feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964)

* feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962)

* fix: chart graph cut off (BAL-3395) (#2969)

* fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968)

* chore(*): updated packages (#2971)

* fix(backoffice-v2): reverted default logic for from and to (#2973)

* refactor(entities): streamline form data context creation (#2974)

- Remove unnecessary context object creation
- Simplify the return statement by directly returning the new context

(your code is like a magic trick that turns objects into empty space)

* fix: remove monitoring params logic from navbar (#2975)

Co-authored-by: Omri Levy <61207713+Omri-Levy@users.noreply.github.com>

* fix: fixed popup flickering in date picker & bump (#2977)

* feat: add a report note when monitoring status is toggled (BAL-3398) (#2979)

* feat: add a report note when monitoring status is toggled

* chore: remove storing reason in metadata

* fix: dmt and dsta rules (#2970)

Co-authored-by: Lior Zamir <liorz@ballerine.com>
Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>

---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Co-authored-by: Sasha <sasham@ballerine.com>
Co-authored-by: Shane <66246046+shanegrouber@users.noreply.github.com>
Co-authored-by: Tomer Shvadron <tomers@ballerine.com>
Co-authored-by: liorzam <6435752+liorzam@users.noreply.github.com>
Co-authored-by: Lior Zamir <liorz@ballerine.com>
Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
@Omri-Levy Omri-Levy mentioned this pull request Jan 21, 2025
Omri-Levy added a commit that referenced this pull request Jan 21, 2025
* feat: updated styles for link elements (#2959)

* feat: added csv document rendering (#2958)

* fix(monitoring): changes the block ordering in website credibility view (#2963)

* feat(monitoring): adds loading state for a single merchant record (BAL-3359) (#2960)

* feat(monitoring): adjusts merchant risk summary text (BAL-3373) (#2961)

* refactor(websiteCredibility): fix CardContent height for no data (#2966)

* refactor(websiteCredibility): fix CardContent height for no data

- Remove unused Tooltip import from recharts
- Update CardContent class to ensure full height

(your code is like a tidy room: looks clean but still has hidden messes)

* empty

* fix: UI fixes for statistics and merchant monitoring report pages (#2965)

* feat(monitoring): adds exhaustive check for action before deboarding a merchant (BAL-3343) (#2964)

* feat(monitoring): preserves scroll position on a data table (BAL-3248) (#2962)

* fix: chart graph cut off (BAL-3395) (#2969)

* fix: corrected home page merchants metrics source of truth (BAL-3396, BAL-3397) (#2968)

* chore(*): updated packages (#2971)

* fix(backoffice-v2): reverted default logic for from and to (#2973)

* refactor(entities): streamline form data context creation (#2974)

- Remove unnecessary context object creation
- Simplify the return statement by directly returning the new context

(your code is like a magic trick that turns objects into empty space)

* fix: remove monitoring params logic from navbar (#2975)



* fix: fixed popup flickering in date picker & bump (#2977)

* feat: add a report note when monitoring status is toggled (BAL-3398) (#2979)

* feat: add a report note when monitoring status is toggled

* chore: remove storing reason in metadata

* fix: dmt and dsta rules (#2970)




---------

Co-authored-by: Illia Rudniev <cheskmr@gmail.com>
Co-authored-by: Sasha <sasham@ballerine.com>
Co-authored-by: Shane <66246046+shanegrouber@users.noreply.github.com>
Co-authored-by: Tomer Shvadron <tomers@ballerine.com>
Co-authored-by: liorzam <6435752+liorzam@users.noreply.github.com>
Co-authored-by: Lior Zamir <liorz@ballerine.com>
Co-authored-by: Alon Peretz <8467965+alonp99@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants