refactor(general info step): prevents NaN values to getting input to …

…fingerprint duration Adds a previous validation to avoid NaN possible values. Also refactors some unnecessary related code on that fix #435
bandada-infra · Apr 3, 2024 · 41a501e · 41a501e
1 parent 2920f64
commit 41a501e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx b/apps/dashboard/src/components/new-group-stepper/general-info-step.tsx
@@ -168,7 +168,10 @@ export default function GeneralInfoStep({
                             size="lg"
                             value={_fingerprintDuration}
                             onChange={(value) =>
-                                setFingerprintDuration(Number(value))
+                                !Number.isNaN(Number(value)) &&
+                                Number(value) >= 0
+                                    ? setFingerprintDuration(Number(value))
+                                    : null
                             }
                             onBlur={() =>
                                 onSubmit(
@@ -205,7 +208,6 @@ export default function GeneralInfoStep({
                         !_groupName ||
                         (group.type === "off-chain" &&
                             (_fingerprintDuration === undefined ||
-                                Number.isNaN(_fingerprintDuration) ||
                                 !_groupDescription ||
                                 _groupDescription.length < 10)) ||
                         _fingerprintDuration < 0