Merge pull request #483 from bandada-infra/fix/api-sdk

Missing `return` statements for removeGroup(s) API SDK methods
bandada-infra · Apr 9, 2024 · a1a8bc1 · a1a8bc1
2 parents 44662c4 + 7949851
commit a1a8bc1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/apps/api/src/app/groups/groups.controller.ts b/apps/api/src/app/groups/groups.controller.ts
@@ -120,14 +120,20 @@ export class GroupsController {
 
         if (apiKey) {
             await this.groupsService.removeGroupsWithAPIKey(groupIds, apiKey)
-        } else if (req.session.adminId) {
+
+            return
+        }
+
+        if (req.session.adminId) {
             await this.groupsService.removeGroupsManually(
                 groupIds,
                 req.session.adminId
             )
-        } else {
-            throw new NotImplementedException()
+
+            return
         }
+
+        throw new NotImplementedException()
     }
 
     @Delete(":group")
@@ -145,14 +151,19 @@ export class GroupsController {
 
         if (apiKey) {
             await this.groupsService.removeGroupWithAPIKey(groupId, apiKey)
-        } else if (req.session.adminId) {
+
+            return
+        }
+        if (req.session.adminId) {
             await this.groupsService.removeGroupManually(
                 groupId,
                 req.session.adminId
             )
-        } else {
-            throw new NotImplementedException()
+
+            return
         }
+
+        throw new NotImplementedException()
     }
 
     @Patch()

diff --git a/libs/api-sdk/src/groups.ts b/libs/api-sdk/src/groups.ts
@@ -133,7 +133,7 @@ export async function updateGroups(
     apiKey: string
 ): Promise<Array<Group>> {
     const newConfig: any = {
-        method: "put",
+        method: "patch",
         data: {
             groupIds,
             groupsInfo: groupsUpdateDetails