Merge pull request #484 from bandada-infra/fix/api-sdk

Avoid wrong `return` in removeGroup(s) API SDK methods
bandada-infra · Apr 9, 2024 · d2cd8d4 · d2cd8d4
2 parents 8f577a6 + 61df1cd
commit d2cd8d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/libs/api-sdk/src/apiSdk.ts b/libs/api-sdk/src/apiSdk.ts
@@ -130,7 +130,7 @@ export default class ApiSdk {
      * @returns undefined.
      */
     async removeGroup(groupId: string, apiKey: string): Promise<void> {
-        return removeGroup(this._config, groupId, apiKey)
+        await removeGroup(this._config, groupId, apiKey)
     }
 
     /**
@@ -140,7 +140,7 @@ export default class ApiSdk {
      * @returns undefined.
      */
     async removeGroups(groupIds: Array<string>, apiKey: string): Promise<void> {
-        return removeGroups(this._config, groupIds, apiKey)
+        await removeGroups(this._config, groupIds, apiKey)
     }
 
     /**

diff --git a/libs/api-sdk/src/groups.ts b/libs/api-sdk/src/groups.ts
@@ -61,9 +61,7 @@ export async function removeGroup(
 
     newConfig.headers["x-api-key"] = apiKey
 
-    const req = await request(requestUrl, newConfig)
-
-    return req
+    await request(requestUrl, newConfig)
 }
 
 /**
@@ -86,9 +84,7 @@ export async function removeGroups(
 
     newConfig.headers["x-api-key"] = apiKey
 
-    const req = await request(url, newConfig)
-
-    return req
+    await request(url, newConfig)
 }
 
 /**