-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a credential to check is a user has >= a specific number of transactions #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hain balance validator
…ain balance validator
0xjei
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing and thank you for introducing the on-chain providers!
…e-credential feat(credentials): add the blockchain balance validator
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new provider named
blockchain
and a new validator namedBLOCKCHAIN_TRANSACTIONS
with a criteria namedminTransactions
.This credential can be used to check if a user has greater than or equal to
minTransactions
transactions.There is a new env variable in the api named
BLOCKCHAIN_SEPOLIA_RPC_URL
. It refers to thesepolia
network. If we would like to add a new network, we will only need to add an PRC URL for the network in the api environment variables. Following the structure ofBLOCKCHAIN_<NETWORK>_RPC_URL
.The URL for this credential would be:
The network in the URL should be the same as the one that appears in its RPC URL environment variable inside the api.
The
block
and theredirect_uri
properties are optional.Related Issue
Closes #369
Does this introduce a breaking change?