Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper ordering of group members #381

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Proper ordering of group members #381

merged 2 commits into from
Feb 18, 2024

Conversation

0xjei
Copy link
Contributor

@0xjei 0xjei commented Feb 9, 2024 •
edited
Loading

Description

To fix #374 we need to

  • switch from Promise.All() to for ... of with internal async/await logic.
  • Enforce ASC ordering for the Created_at field.

A test has been adapted to demonstrate that everything is working.

Related Issue

closes #374

Does this introduce a breaking change?

  • Yes
  • No

@0xjei 0xjei requested a review from vplasencia February 9, 2024 10:41
@0xjei 0xjei self-assigned this Feb 9, 2024
@0xjei 0xjei marked this pull request as draft February 9, 2024 14:47
@0xjei 0xjei marked this pull request as ready for review February 9, 2024 15:51
vplasencia
vplasencia approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ✨

@vplasencia vplasencia merged commit 5c8341a into dev Feb 18, 2024
2 checks passed
@vplasencia vplasencia deleted the fix/member-wrong-order branch March 6, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

Assignees

@0xjei 0xjei

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xjei @vplasencia