Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix peer dependencies #390

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

baumstern
Copy link
Contributor

Description

This PR fixes #389. Also the failure mentioned in #386 (comment).

Related Issue

#389

Does this introduce a breaking change?

  • Yes
  • No

@baumstern baumstern mentioned this pull request Feb 14, 2024
2 tasks
@0xjei 0xjei self-requested a review February 16, 2024 15:45
Copy link
Contributor

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat 👍 Thank you :)

@0xjei 0xjei changed the base branch from main to dev February 16, 2024 17:12
@vplasencia vplasencia merged commit a5e0153 into bandada-infra:dev Feb 19, 2024
2 checks passed
@baumstern baumstern deleted the fix/dependencies branch February 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing peer dependencies
3 participants