Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EAS provider with default EAS_ATTESTATIONS validator #392

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

0xjei
Copy link
Contributor

@0xjei 0xjei commented Feb 15, 2024

Description

This PR integrates the Ethereum Attestation Service (EAS) provider with an EAS_ATTESTATIONS validator that takes minAttestation criteria for validation.

Related Issue

partially related to #355

Does this introduce a breaking change?

  • Yes
  • No

Other information

This is the starting point for completing the #355

@0xjei 0xjei requested a review from vplasencia February 15, 2024 17:44
Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Great work ✨

@0xjei
Copy link
Contributor Author

0xjei commented Feb 19, 2024

Looks great! Great work ✨

Thank you 😊 I will open a new PR for introducing other fields on the attestations. We can merge this whenever :)

@vplasencia vplasencia merged commit eeec708 into dev Feb 19, 2024
2 checks passed
@vplasencia vplasencia deleted the integration/eas branch March 6, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants