-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website setup #455
Website setup #455
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! @kalidiagne thank you very much. Great work. It looks really nice.
I left one comment.
Is it ok to remove the package-lock.json
file, because we are using yarn
?
There are some issues related to eslint
and prettier
. We can take a look later.
I found the same bug - thx for reporting @vplasencia |
oh, this is super odd, can you please try again? cc: @0xjei |
Thank you for the feedback, following the response for every point The navbar contains Documentation and Github link. Should we open these in a new window as we do when pressing the Lunch App button? I have noticed that most text is not centered when on mobile. Join the Bandada community section with the Discord button. Is this necessary since we have another link to Discord on the footer? Projects built with Bandada section seems to be not left-start aligned, resulting in some left margin (same happening on mobile). |
Hey @kalidiagne! Interesting. I tried to go to the build page again and I still see 404: Page not found. Could it be related to a missing folder called |
Ah i see, i just updated the URL path name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now, tysm for the updates!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kalidiagne thank you very much for the great work. Just left two comments. I think after those comments, everything is ready. Thank you very much 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much 💯
closing for #523 |
Description
Bandada website setup & structure
Related Issue
Does this introduce a breaking change?
Other information