Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api,api-sdk): add getGroupsByAdminId() and getGroupsByMemberId() #524

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

waddaboo
Copy link
Contributor

@waddaboo waddaboo commented Jun 7, 2024

Description

Added new api-sdk features that allows users to get groups based on adminId and memberId.

Related Issue

Closes #493

Move PR #519 from dev branch to main branch

Does this introduce a breaking change?

  • Yes
  • No

Other information

Changed where from array to object so that it will return results for AND instead of OR when both adminId and memberId is present in the query.

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 3:09pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 8, 2024 3:09pm

@waddaboo
Copy link
Contributor Author

waddaboo commented Jun 7, 2024

Hey @vplasencia! Moved the commits to a new branch as requested, please have a look :)

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @waddaboo thank you very much for the great work.

Just left one comment.

apps/api/src/app/groups/groups.controller.ts Show resolved Hide resolved
Co-authored-by: Vivian Plasencia <v.pcalana@gmail.com>
@vplasencia vplasencia merged commit dd5e640 into bandada-infra:main Jun 10, 2024
5 checks passed
@waddaboo waddaboo deleted the dev-493 branch July 4, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all the groups per AdminID
3 participants