-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(groupsValidation): throw BadRequestException on invalid treeDepth input #582
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@vplasencia of course yes!!! |
Thank you @sanieni6! Please, let us know if you have any questions. |
Hi @vplasencia it is done, please let me know if you need something else!! 😄 |
Thank you very much @sanieni6! 🙏 Could you add tests for the changes and also run |
Hi @vplasencia tests just created!! I ran |
Hey @sanieni6 thank you very much for creating the tests, I will take a look asap. Regarding prettier, it's fine now, no need to push those other changes. Thank you for asking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @sanieni6 great work! Thank you very much. I just left one comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you very much! 🙏
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Bandada Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Thanks @sanieni6 ❤️ |
Description
This pull request adds validation to ensure that the
treeDepth
parameter is within the supported range of 16 to 32 inclusive when creating new groups. If an invalidtreeDepth
is provided, the API now returns a clear and descriptive error message by throwing aBadRequestException
.Related Issue
This pull request addresses #579
Does this introduce a breaking change?
Other information
treeDepth == 15
treeDepth == 33
treeDepth == 18