Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-sdk): add getMultipleCredentialsGroupJoinUrl #607

Merged

Conversation

waddaboo
Copy link
Contributor

Description

This PR introduces a new API SDK that allows users to generate a link to join multiple credentials group.

Related Issue

Issue #606

Does this introduce a breaking change?

  • Yes
  • No

Other information

Opted to add new API SDK method instead of updating the existing getCredentialGroupJoinUrl to prevent breaking change.

@waddaboo waddaboo requested a review from vplasencia November 29, 2024 09:48
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:50am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 9:50am

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you @waddaboo

@vplasencia vplasencia merged commit 77144d1 into dev Nov 29, 2024
5 checks passed
@waddaboo waddaboo deleted the feat/api-sdk/generate-multiple-credentials-group-join-url branch November 29, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants