fix(client): disable input when user joins via an invite link #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable `credential group id` input when user joins a group via an invite link with an inviteCode. Also, disable `invite code` input when user joins a group via an invite link with a credentialGroupId bandada-infra#270
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vplasencia
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Hey @bellodamilola! It looks great! Thank you very much! Could you run yarn prettier:write and then push the changes to fix code styling?
vplasencia
approved these changes
Dec 2, 2024
|
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2024 Bandada Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes an issue that occurs when a user joins a group via the invite link with an
inviteCodeand clicks theCredential group IDinput, the invite input gets cleared. And also vice versa.Related Issue
Fix: #270
Does this introduce a breaking change?