Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): use API SDK for credential group and multiple credentials group #615

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

waddaboo
Copy link
Contributor

@waddaboo waddaboo commented Dec 4, 2024

Description

This PR updates the current generate join url method in the Client app to use API SDK instead.

This feature has been added for both credential group and multiple credentials group.

Related Issue

Issue #612

Does this introduce a breaking change?

  • Yes
  • No

Other information

@waddaboo waddaboo requested a review from vplasencia December 4, 2024 10:16
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:20am
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:20am

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you @waddaboo

@vplasencia vplasencia merged commit 48c539a into dev Dec 5, 2024
5 checks passed
@waddaboo waddaboo deleted the feat/client/credential-group-api-sdk branch December 6, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants