Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(groups.tsx): make groups responsive for small and medium screen #642

Merged
merged 3 commits into from
Dec 27, 2024

Conversation

yagopajarino
Copy link
Contributor

@yagopajarino yagopajarino commented Dec 17, 2024

re #557

Description

Refactor the UX code to make the groups stack (My groups and All Credential Groups) responsive for small and medium screens.

Also refactors the search bar and add group button to fit them in small/medium screens

Does this introduce a breaking change?

  • Yes
  • No

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:54pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 9:54pm

@yagopajarino
Copy link
Contributor Author

yagopajarino commented Dec 17, 2024

Hi @vplasencia PR for issue #557. Let me know what you think :)

Should look like this

image

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yagopajarino! Thank you very much for this PR. I added some suggestions.

After the suggestions, it should look like:

Screen.Recording.2024-12-20.at.9.46.43.PM.mov

It's good to always test how the width changes on smaller screens (to try all possible smaller screens) by using the responsive option in Google Chrome, for example and also try how it would look on different devices with different dimensions.

apps/dashboard/src/pages/groups.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/pages/groups.tsx Outdated Show resolved Hide resolved
apps/dashboard/src/pages/groups.tsx Outdated Show resolved Hide resolved
@yagopajarino
Copy link
Contributor Author

Hi @vplasencia ! Thanks for the feedback. Just made the changes following the suggestions

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Thank you very much! 💯

@vplasencia vplasencia changed the base branch from main to dev December 27, 2024 14:03
@vplasencia vplasencia changed the base branch from dev to main December 27, 2024 14:04
@vplasencia vplasencia changed the base branch from main to dev December 27, 2024 14:04
@vplasencia vplasencia merged commit 22a8c5f into bandada-infra:dev Dec 27, 2024
2 checks passed
Copy link

gitpoap-bot bot commented Dec 27, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Bandada Contributor:

GitPOAP: 2024 Bandada Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants