Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make connected account button responsive for small sreens #647

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

yagopajarino
Copy link
Contributor

re #641

Description

Make the connected account button responsive for small screens to prevent overlapping with bandada logo

Does this introduce a breaking change?

  • Yes
  • No

Other information

Small screens
image

Medium/large screens
image

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bandada-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 1:49pm
bandada-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2024 1:49pm

@yagopajarino
Copy link
Contributor Author

Hi @vplasencia PR for #641

I noticed I’m not actually assigned to this one, but I went ahead and tackled it anyway :)

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @yagopajarino! I left a comment.

apps/dashboard/src/components/navbar.tsx Show resolved Hide resolved
@yagopajarino
Copy link
Contributor Author

Hi @vplasencia! Let me know if it's okay now, thanks!

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thank you very much @yagopajarino 🚀

@vplasencia vplasencia changed the base branch from main to dev January 9, 2025 23:18
@vplasencia vplasencia merged commit 310c5a3 into bandada-infra:dev Jan 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connected button overlapping bandada logo on small screens
2 participants