PCE-89 Update company name and invoice contact information in AWS #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornrog
commented
May 21, 2024
bjornrog
commented
- Update primary contact information
- Added support for maintaining master account contact information
- Added support for deployment into the master account (no delegated admin for contacts)
- Prepare for deployment into every customer master account:
- Providing sane defaults
- Making sure lambda is run when terraform apply is done
…cross all customer master accounts
…unts for controlling alternate contact email
stonefield
requested changes
May 23, 2024
There was a problem hiding this comment.
Maybe the Usage section should be updated...
There was a problem hiding this comment.
Actually I think I must refactor the deployment in https://github.com/basefarm/bf-internal-security/tree/main/account. Move the contact administration to the master account.
This way we do not actually need the "delegated admin" support, thus there will be only one module, and usage must be updated accordingly.
There was a problem hiding this comment.
Should the override tags be documented (tds:contact:*)
| if error.response['Error']['Code'] == 'ResourceNotFoundException': | ||
| pass | ||
| else: | ||
| raise error | ||
| pass |
| except ClientError as error: | ||
| FAILED_ACCOUNTS.append(accountId) | ||
| print(error) | ||
| pass |
There was a problem hiding this comment.
Agree, was in the original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.