Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebar 3.7.x compatibility #3

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nalundgaard
Copy link

  • add compatibility with new resource format introduced in rebar 3.7.0 in backwards-compatible way.

daniel-zinov and others added 2 commits November 26, 2018 12:46
* Move code handling rebar v2 resources to dedicated head and check it more reliably (`is_rec_type` check)
* Restore old format check for "legacy" resources (when using rebar3 <3.7.0)
@nalundgaard
Copy link
Author

Don't merge this just yet, still testing it.

@nalundgaard nalundgaard force-pushed the rebar_3.7_compat branch 2 times, most recently from c65406b to 577cae6 Compare November 26, 2018 23:25
@nalundgaard nalundgaard force-pushed the rebar_3.7_compat branch 6 times, most recently from 4695d66 to fd7497b Compare December 7, 2018 04:04
@nalundgaard nalundgaard force-pushed the rebar_3.7_compat branch 4 times, most recently from ee9ea74 to f88335f Compare December 19, 2018 20:18
Implement rebar_resource_v2 compatible callbacks in order to make the plugin compatible with all known versions of rebar3, following the guide at https://www.rebar3.org/v3/docs/custom-dep-resources#section-resources-compatible-with-all-versions
@lrascao
Copy link

lrascao commented Apr 7, 2019

@nalundgaard maybe you guys at Alert Logic could take over this project? i'm not seeing this getting merged any time sooner...

@nalundgaard
Copy link
Author

nalundgaard commented Apr 7, 2019

That is effectively what we’ve done, I suppose. I don’t know if anyone even has access to the basho organization now, maybe @mrallen1 would know? Anyway, I forked the repo to alertlogic/rebar_raw_resource and published it to hex.

@lrascao
Copy link

lrascao commented Apr 7, 2019

ah cool, i didn't see 0.9.0 tagged there, thanks!

@jadeallenx
Copy link

I've only seen merges on Riak stuff. @martinsumner do you know who at Bet365 could maybe merge this or add maintainers to this project?

@martinsumner
Copy link

@martincox is the one for adding new maintainers. However, I don't think this is used anywhere within Riak, so it might be better to switch this out of the basho domain.

@martincox
Copy link

Do alertlogic want to take over the repo? I can transfer to a new org if that is preferred?

@nalundgaard
Copy link
Author

That is fine for me, we can take it over. @motobob any objections to that?

@nalundgaard
Copy link
Author

@martincox are you still interested in transferring this to us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants