-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rebar 3.7.x compatibility #3
base: master
Are you sure you want to change the base?
Conversation
nalundgaard
commented
Nov 26, 2018
- add compatibility with new resource format introduced in rebar 3.7.0 in backwards-compatible way.
* Move code handling rebar v2 resources to dedicated head and check it more reliably (`is_rec_type` check) * Restore old format check for "legacy" resources (when using rebar3 <3.7.0)
Don't merge this just yet, still testing it. |
c65406b
to
577cae6
Compare
4695d66
to
fd7497b
Compare
ee9ea74
to
f88335f
Compare
Implement rebar_resource_v2 compatible callbacks in order to make the plugin compatible with all known versions of rebar3, following the guide at https://www.rebar3.org/v3/docs/custom-dep-resources#section-resources-compatible-with-all-versions
f88335f
to
e7576aa
Compare
@nalundgaard maybe you guys at Alert Logic could take over this project? i'm not seeing this getting merged any time sooner... |
That is effectively what we’ve done, I suppose. I don’t know if anyone even has access to the basho organization now, maybe @mrallen1 would know? Anyway, I forked the repo to alertlogic/rebar_raw_resource and published it to hex. |
ah cool, i didn't see |
I've only seen merges on Riak stuff. @martinsumner do you know who at Bet365 could maybe merge this or add maintainers to this project? |
@martincox is the one for adding new maintainers. However, I don't think this is used anywhere within Riak, so it might be better to switch this out of the basho domain. |
Do alertlogic want to take over the repo? I can transfer to a new org if that is preferred? |
That is fine for me, we can take it over. @motobob any objections to that? |
@martincox are you still interested in transferring this to us? |