scummvm: fix stretch_mode #13196
scummvm: fix stretch_mode #13196
Conversation
|
current center stretch:
fit stretch (or default):
|
|
Perfect :) |
There was a problem hiding this comment.
else:
commandArray.append("--stretch-mode=center")
Keep that in there, but change --stretch-mode=center to --stretch-mode=fit otherwise there's no default value in the configgen for --stretch-mode=.
There was a problem hiding this comment.
Just updated the code. Simply keep the default (auto) -> no value , and don't force parameter in command line.
Like this, it'll use the default fit in nothing is defined in scummvm.ini and will use custom value that user could has done from scummvm gui/ini.
There was a problem hiding this comment.
Please align formatting like this:
"Fit resolution scale (Default)": "fit"
"Center": "center"
"Pixel Perfect": "pixel-perfect"
"Even Pixels": "even-pixels"
"Stretch to screen": "stretch"
"Fit 4:3 Aspect Ratio": "fit_force_aspect"
There was a problem hiding this comment.
in fact, the biggest issue is that if you force the --stretch-mode with a value in scummvmGenerator.py, you can't change it manually afterwards, the value always remains (even if you specify it in the ini, the value takes over).
the --stretch-mode=fit is the default mode in scummvm, but allows you to change mode later if you wish, via scummvm.ini.
By adding a value to the configgen, it's impossible to change it afterwards.
There was a problem hiding this comment.
ok, so maybe we should have a default value : "auto" instead ? what do you think about it @Tovarichtch ?
There was a problem hiding this comment.
"auto" is no command line, so keep "fit" is nothing is defined in scummvm.ini. This allow user to do specific stretch mode customization directly in scummvm.ini or scummvm gui.
since batocera-linux@8cc8b27, default stretch mode is broken. The default stretch_mode of scummvm (if not defined in command line) is "fit", not "center". (Center don't scale at all, so if you have a 4k screen with a 320x200 games, it'll be displayed too small) This patch simply don't force it command line also, es_features.yml is buggy, as "center" value is currently defined in french "centre"
aderumier
force-pushed
the
scummvm_stretchfix
branch
from
9eb76e4 to
a7225f2
Compare
since 8cc8b27, default stretch mode is broken.
The default stretch_mode of scummvm (if not defined in command line) is "fit", not "center". (Center don't scale at all, so if you have a 4k screen with a 320x200 games, it'll be displayed too small)
This patch simply don't force it command line
also, es_features.yml is buggy, as "center" value is currently defined in french "centre". (and scummvm is fallbacking to "fit" if a wrong value is defined)