Fix go_deps warnings #2003
Merged
Fix go_deps warnings #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Only show a warning for version mismatches between `go.mod` and `bazel_dep` if the dep is either a direct dep or the Bazel module version is lower. This avoids noisy warnings, in particular on gazelle itself due to its `go.mod` dependency on `rules_go`. * Don't suggest importing deps from isolated usages that are shared with the non-isolated usage.
tyler-french
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What package or component does this PR mostly affect?
go_deps
What does this PR do? Why is it needed?
go.modandbazel_depif the dep is either a direct dep or the Bazel module version is lower. This avoids noisy warnings, in particular on gazelle itself due to itsgo.moddependency onrules_go.Which issues(s) does this PR fix?
Fixes bazel-contrib/rules_go#4199
Work towards #1990
Other notes for review