Skip to content

Commit

Permalink
Update protobuf to version that does not define @maven repo in it's M…
Browse files Browse the repository at this point in the history
…ODULE.bazel (#1188)
  • Loading branch information
cheister authored Jul 1, 2024
1 parent eb1adad commit 5f6f2f4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,12 @@ http_file(

bazel_dep(
name = "protobuf",
version = "21.7",
# Note: we use 27.2 in MODULE.bazel to avoid the warning:
# The maven repository 'maven' is used in two different bazel modules, originally in 'rules_jvm_external' and now in 'protobuf'
# But we use 21.7 in WORKSPACE because protobuf 27.2 doesn't work with Bazel 5.x
# https://github.com/protocolbuffers/protobuf/commit/a80daa2a2caaaac9ebe9ae6bb1b639c2771c5c55
# This should be ok because we only use the protobuf dep to pull in the google/protobuf/wrappers.proto for testing
version = "27.2",
dev_dependency = True,
)
bazel_dep(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -420,8 +420,8 @@ private List<Dependency> createManagedDependencies(
// },
//
// In order to keep the version consistent across all classifiers we use the first version for
// the
// artifact in the dependency list as the version for all of the classifiers of the artifact.
// the artifact in the dependency list as the version for all of the classifiers of the
// artifact.
//
// Note: This is different from the coursier resolver which will use the last artifact in the
// dependency list for the version of all of that dependency with classifiers.
Expand Down

0 comments on commit 5f6f2f4

Please sign in to comment.