Skip to content

Commit

Permalink
chore: follow-up to remove the other eslint_test in next.js example (#…
Browse files Browse the repository at this point in the history
…374)

I just missed this in the previous PR.
  • Loading branch information
alexeagle authored Dec 6, 2023
1 parent 53d1344 commit a606e28
Show file tree
Hide file tree
Showing 14 changed files with 59,004 additions and 55,170 deletions.
7 changes: 5 additions & 2 deletions frontend/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ build --enable_runfiles
###########################
# Linting
# Enable with --config=lint
build:lint --aspects=//next.js:lint.bzl%eslint
# Gather lint reports
# This is demonstrated by the next.js example:
# cd next.js; npm run lint
build:lint --aspects=//:lint.bzl%eslint
# Gather lint reports.
# Note: --remote_download_regex is for RBE and was added in Bazel 7.
build:lint --output_groups=rules_lint_report --remote_download_regex='.*aspect_rules_lint.report'
# Cause build failures when there are lint warnings.
# This is a simple configuration, but you probably want to report them as code review comments instead.
Expand Down
5 changes: 5 additions & 0 deletions frontend/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
"Root BUILD file for all frontend examples"

load("@npm//:defs.bzl", "npm_link_all_packages")
load("@npm//:eslint/package_json.bzl", eslint_bin = "bin")

package(default_visibility = ["//:__subpackages__"])

# Create the root of the "virtual store" of npm dependencies under bazel-out.
# This must be done in the package where the pnpm workspace is rooted.
npm_link_all_packages(name = "node_modules")

eslint_bin.eslint_binary(name = "eslint")
6 changes: 6 additions & 0 deletions frontend/MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ bazel_dep(name = "aspect_rules_rollup", version = "1.0.0")
bazel_dep(name = "aspect_rules_webpack", version = "0.13.0")
bazel_dep(name = "bazel_skylib", version = "1.4.2")

git_override(
module_name = "aspect_rules_lint",
commit = "270a3ea55ba4ee75f8fe15636c053c1cc7941e41",
remote = "https://github.com/aspect-build/rules_lint",
)

pnpm = use_extension("@aspect_rules_js//npm:extensions.bzl", "pnpm")
use_repo(pnpm, "pnpm")

Expand Down
Loading

0 comments on commit a606e28

Please sign in to comment.