-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate dSYM bundles discovered within imported dynamic xcframeworks #2625
Propagate dSYM bundles discovered within imported dynamic xcframeworks #2625
Conversation
fa84986
to
767820d
Compare
d4a85d4
to
5aa55b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me but im also no expert here. The test looks good though and generally like some of the refactoring that was done.
Could we update the PR description/commit to go into more details, potentially show-casing an example with expected inputs/outputs. I think that would help make things more understandable.
Fixes #2512
This PR attempts to add automatic dSYM imports per target-triple for dynamic xcframeworks. It is a rough implementation with some appropriately sharp edges, due to my still-nascent familiarity with the codebase, but I've managed to prove it out at the day job. Hopefully this is acceptable!
For example, given a dependency on Sentry's dynamic xcframework, which vends dSYMs:
bazel cquery --output=files --output_groups=+dsyms --apple_generate_dsym //examples/ios/HelloWorldSwift
Before
After
After (ios_arm64)
Note: dSYMs for dynamic xcframeworks imported from outside the root module are not copied into bazel-out and their paths as viewed with cquery are under
external/
relative to the output base. This is consistent with howdsym_imports
are handled byapple_dynamic_framework_import
.