Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typos hook and fix typos #921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Jan 17, 2025

Motivated by #920 this PR add the typos pre-commit hook and autofixes all typos found by the hook

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.

Copy link
Collaborator

@aiuto aiuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup.The failing tests are very strange. Zip file stuff.

Traceback (most recent call last):
  File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/266/execroot/_main/bazel-out/k8-fastbuild/bin/tests/zip/zip_test.runfiles/_main/tests/zip/zip_test.py", line 57, in test_basic
    self.assertZipFileContent("test_zip_basic.zip", expect)
  File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/266/execroot/_main/bazel-out/k8-fastbuild/bin/tests/zip/zip_test.runfiles/_main/tests/zip/zip_test_lib.py", line 68, in assertZipFileContent
    self.assertEqual(info.CRC, expected["crc"])
AssertionError: 1744041596 != 2178844372

This smells like the tests are flaky w.r.t. zip implementation.
Or, just they depend the words in a file. Perhaps tests/testdata/loremipsum.txt

Which I just confirmed.
Can you back out that file, or update the CRCs in the zip_test.

@hofbi
Copy link
Contributor Author

hofbi commented Jan 17, 2025

I reverted the change in the testdata and exclude them from the typos hook. This was anyhow a wrong fix since the only works for english and not latin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants