Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clojure-cheatsheet to prelude-clojure #464

Closed
wants to merge 1 commit into from
Closed

Add clojure-cheatsheet to prelude-clojure #464

wants to merge 1 commit into from

Conversation

ToBeReplaced
Copy link
Contributor

No description provided.

@bbatsov
Copy link
Owner

bbatsov commented Dec 30, 2013

Unfortunately the cheatsheet depends on helm which is a huge package and I'm not sure I want to impose this on all the users (since they'll have to keep updating it afterwards frequently). It would have been much better if it provided alternative "front-end" options or if helm was packaged in some more minimalistic manner (currently the default package features a ton of plugins). As it stands - byte-compiling helm takes about as much time as all the packages Prelude depends on. I'd like to see the cheatsheet featuring an alternative ido-based UI //cc @krisajenkins

@krisajenkins
Copy link

It's certainly an option. There's actually very little to the clojure-cheatsheet code that has anything to do with helm. It's just the final step in the chain.

The only tricky part I foresee is making clojure-cheatsheet dependent on helm OR ido. It'd be easy enough to determine which one you've got at runtime, but ensuring you had one or other at install time...that I'm not sure about. Any ideas?

And other than that, there's the fact that I've not used ido - at least, not for more than the hour I spent deciding between it and helm a year ago - but I'm sure it can't be too hard to figure out. :-}

@bbatsov
Copy link
Owner

bbatsov commented Dec 30, 2013

ido is always available, as it's bundled with Emacs, so there's no need to check for its presence. I'd suggest that you simply utilize a completion-ui defcustom, that's be set by default by checking for the presence of helm with fboundp (or explicitly set by the users. If they select helm but don't have it installed you can display a messaged prompting them to install it or directly run (package-install 'helm)).

Alternatively you can do what I do in projectile - supply an extra helm-projectile package, that depends on helm and contains the helm specific code.

@krisajenkins
Copy link

Okay, I've opened this as a clojure-cheatsheet issue.

@bbatsov
Copy link
Owner

bbatsov commented Mar 2, 2014

@krisajenkins Any progress?

@krisajenkins
Copy link

Ah, I must confess this has slipped my mind. I'll be putting a new release together aroundabout the time Clojure 1.6 goes official, so I'll probably handle it then & revisit the code all at once. :-}

@bbatsov
Copy link
Owner

bbatsov commented Apr 10, 2014

@krisajenkins OK

@bbatsov bbatsov closed this May 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants