Lock pipenv version to a compatible one with the python version on ubuntu 18.04. Install sanic through pipfile #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untu 18.04. Install sanic through pipfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change locks the pipenv version to the last known good version that works with the python shipped on Ubuntu 18.04
Also, removed sanic installation through pip as the requirement is defined through Pipfile.
This makes the docker image workable, but webrtc output is broken due to the Gstremaer version being 1.4. It seems current code requires bundle-policy property for webrtcbin, which is available for Gstreamer > 1.6