Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass interface rather than string values to helm #93

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

dkeven
Copy link
Contributor

@dkeven dkeven commented Oct 17, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

pass map[string]string as values to helm sdk will result in it cannot be merged with the chart's values.yaml, map[string]interface{} should be passed instead.

@dkeven dkeven requested a review from eball October 17, 2024 14:49
@eball eball merged commit 45ae2c2 into main Oct 17, 2024
1 check passed
@dkeven dkeven deleted the fix/helm_interface_val branch October 17, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants