Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scaffold the project for Webhook setup #237

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat: Scaffold the project for Webhook setup #237

merged 1 commit into from
Jan 22, 2025

Conversation

portly-halicore-76
Copy link
Contributor

@portly-halicore-76 portly-halicore-76 commented Jan 7, 2025 •
edited
Loading

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

No webhooks are in place in the Paas project.

Fixes: #233

What is the new behavior?

  • The project is scaffolded with webhooks which validate nothing
  • The test setup for webhooks, using EnvTest is in place
  • There are placeholders for implementing the checks which are executed by the webhooks.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the ci label Jan 7, 2025
@portly-halicore-76 portly-halicore-76 force-pushed the feat/webhook-scaffold branch 3 times, most recently from 4ffb0c1 to defa0b9 Compare January 10, 2025 10:08
@github-actions github-actions bot added the enhancement New feature or request label Jan 10, 2025
@portly-halicore-76 portly-halicore-76 force-pushed the feat/webhook-scaffold branch 3 times, most recently from c12aea2 to 50e1311 Compare January 21, 2025 10:41
@portly-halicore-76 portly-halicore-76 marked this pull request as ready for review January 21, 2025 10:42
@portly-halicore-76 portly-halicore-76 requested a review from a team as a code owner January 21, 2025 10:42
@portly-halicore-76 portly-halicore-76 force-pushed the feat/webhook-scaffold branch 7 times, most recently from 54562cf to a4bd6d6 Compare January 21, 2025 14:15
hikarukin
hikarukin requested changes Jan 21, 2025
View reviewed changes
api/v1alpha1/paas_webhook.go Outdated Show resolved Hide resolved
api/v1alpha1/paas_webhook_test.go Outdated Show resolved Hide resolved
api/v1alpha1/paas_webhook.go Show resolved Hide resolved
api/v1alpha1/webhook_suite_test.go Outdated Show resolved Hide resolved
api/v1alpha1/webhook_suite_test.go Show resolved Hide resolved
manifests/manager/opr-paas-deployment.yaml Show resolved Hide resolved
@portly-halicore-76 portly-halicore-76 force-pushed the feat/webhook-scaffold branch 2 times, most recently from b5566f3 to 01aaec3 Compare January 22, 2025 06:40
@portly-halicore-76
* Fixes belastingdienst#233
cf2b6b3 
Signed-off-by: portly-halicore-76 <170707699+portly-halicore-76@users.noreply.github.com>
@portly-halicore-76 portly-halicore-76 merged commit e99b8dd into belastingdienst:main Jan 22, 2025
11 checks passed
@portly-halicore-76 portly-halicore-76 deleted the feat/webhook-scaffold branch January 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AxiomaticFixedChimpanzee AxiomaticFixedChimpanzee AxiomaticFixedChimpanzee approved these changes

@hikarukin hikarukin hikarukin approved these changes

Assignees
No one assigned
Labels
ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Scaffold project to allow for webhooks
3 participants
@portly-halicore-76 @hikarukin @AxiomaticFixedChimpanzee