feat: Use decryptSecrets from Kubernetes #242
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portly-halicore-76
force-pushed
the
feat/decryptsecret-from-k8s
branch
2 times, most recently
from
d7cd425 to
4f6d69a
Compare
* Some minor refactoring in the crypt area Signed-off-by: portly-halicore-76 <170707699+portly-halicore-76@users.noreply.github.com>
portly-halicore-76
force-pushed
the
feat/decryptsecret-from-k8s
branch
from
4f6d69a to
1b4d58e
Compare
Signed-off-by: portly-halicore-76 <170707699+portly-halicore-76@users.noreply.github.com>
| @@ -53,6 +53,10 @@ type PaasConfigSpec struct { | |||
| // +kubebuilder:validation:Required | |||
| DecryptKeyPaths []string `json:"decryptKeyPaths"` | |||
There was a problem hiding this comment.
This one can go, right?
There was a problem hiding this comment.
Thats a breaking change. We are allowed to do that in an alpha api. If we agree, let's do that. Else, we need to support both which makes this feature more complex. Let me know what you think is appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Fixes: #241
What is the new behavior?
Does this introduce a breaking change?
Other information