Feature/install cmake config package #32

ClausKlein · 2024-11-24T21:34:09Z

FIXME: the exported package is not usable
depends on Feature/modernize cmake #33

NOTE: This is second of a series of PR based on #14

ClausKlein · 2024-11-27T06:55:41Z

CMakeLists.txt

+# export cmake config package
+set(TARGET_NAME inplace_vector)
+set(TARGET_NAMESPACE beman)
+set(TARGET_ALIAS ${TARGET_NAMESPACE}::${TARGET_NAME})
+set(TARGET_PREFIX ${TARGET_NAMESPACE}.${TARGET_NAME}) # -> PROJECT_NAME?
+set(TARGET_PACKAGE_NAME ${TARGET_NAME}-config)
+set(TARGETS_EXPORT_NAME ${TARGET_NAME}-targets)
+set(INSTALL_CONFIGDIR ${CMAKE_INSTALL_LIBDIR}/cmake/${TARGET_NAME})
+


NOTE: we need a decision about this settings: This variant is not usable!

bash-5.2$ cmake -S . -B build -G Ninja -D CMAKE_BUILD_TYPE=Debug --fresh -- The CXX compiler identification is Clang 19.1.3 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/local/opt/llvm/bin/clang++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- Examples to be built: fibonacci -- Configuring done (0.9s) -- Generating done (0.0s) -- Build files have been written to: /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build bash-5.2$ ninja -C build ninja: Entering directory `build' [8/8] Linking CXX executable examples/beman.inplace_vector.examples.fibonacci bash-5.2$ ninja -C build test ninja: Entering directory `build' [0/1] Running tests... Test project /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build Start 1: beman.inplace_vector.test 1/3 Test #1: beman.inplace_vector.test ........ Passed 0.24 sec Start 2: find-package-test 2/3 Test #2: find-package-test ................***Failed 1.10 sec Start 3: fibonacci 3/3 Test #3: fibonacci ........................ Passed 0.24 sec 67% tests passed, 1 tests failed out of 3 Total Test time (real) = 1.59 sec The following tests FAILED: 2 - find-package-test (Failed) Errors while running CTest Output from these tests are in: /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/Testing/Temporary/LastTest.log Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely. FAILED: CMakeFiles/test.util cd /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build && /usr/local/bin/ctest --force-new-ctest-process ninja: build stopped: subcommand failed. bash-5.2$ cd build bash-5.2$ ctest --rerun-failed --verbose UpdateCTestConfiguration from :/Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/DartConfiguration.tcl UpdateCTestConfiguration from :/Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/DartConfiguration.tcl Test project /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build Constructing a list of tests Done constructing a list of tests Updating test list for fixtures Added 0 tests to meet fixture requirements Checking test dependency graph... Checking test dependency graph end test 2 Start 2: find-package-test 2: Test command: /usr/local/bin/ctest "--verbose" "--output-on-failure" "-C" "Debug" "--build-and-test" "/Users/clausklein/Workspace/cpp/beman-project/inplace_vector/examples" "/Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/tests/beman/inplace_vector/find-package-test" "--build-generator" "Ninja" "--build-makeprogram" "/usr/local/bin/ninja" "--build-options" "-DCMAKE_CXX_COMPILER=/usr/local/opt/llvm/bin/clang++" "-DCMAKE_CXX_STANDARD=20" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_PREFIX_PATH=/usr/local" 2: Working Directory: /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/tests/beman/inplace_vector 2: Test timeout computed to be: 10000000 2: Internal cmake changing into directory: /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/tests/beman/inplace_vector/find-package-test 2: Error: cmake execution failed 2: Examples to be built: fibonacci 2: Configuring done (0.0s) 2: CMake Error at CMakeLists.txt:22 (target_link_libraries): 2: Target "beman.inplace_vector.examples.fibonacci" links to: 2: 2: beman::inplace_vector 2: 2: but the target was not found. Possible reasons include: 2: 2: * There is a typo in the target name. 2: * A find_package call is missing for an IMPORTED target. 2: * An ALIAS target is missing. 2: 2: 2: 2: Generating done (0.0s) 2: CMake Generate step failed. Build files cannot be regenerated correctly. 2: 1/1 Test #2: find-package-test ................***Failed 0.06 sec 0% tests passed, 1 tests failed out of 1 Total Test time (real) = 0.07 sec The following tests FAILED: 2 - find-package-test (Failed) Errors while running CTest Output from these tests are in: /Users/clausklein/Workspace/cpp/beman-project/inplace_vector/build/Testing/Temporary/LastTest.log Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely. bash-5.2$

What are you trying to say here?

the beman naming conventions are not usable!

ClausKlein · 2024-11-27T07:11:01Z

CMakeLists.txt

 add_library(beman.inplace_vector INTERFACE)
 # [CMAKE.LIBRARY_ALIAS]
 add_library(beman::inplace_vector ALIAS beman.inplace_vector)


The library (export target) must named inplace_vector only!

Within beman project, this should be unique and with the this exported ALIAS, it is right.

What change are you suggesting here specifically??? This comment is very confusing

the beman name conventions prevent using and installed cmake config package!

What do you mean it prevents CMake config package? Can you provide more details

Use FILE_SET HEADERS for simplify installation Set VERIFY_INTERFACE_HEADER_SETS property Prevent use of include(CTest) Prepare CPack to easy distribution Add all_verify_interface_header_sets to CI builds Prevent in-source builds Ignore cmake configure trash

Co-authored-by: David Sankel <camior@gmail.com>

Add find-package-test Prevent undefined cmake values

wusatosi · 2024-12-06T08:24:55Z

CMakeLists.txt

 # [CMAKE.LIBRARY_ALIAS]
-add_library(beman::inplace_vector ALIAS beman.inplace_vector)
+add_library(beman::beman_inplace_vector ALIAS beman_inplace_vector)


This is non conforming

see #32 (comment)

Please try yourself to make it work with confirming names!

Wdym try to make it work?

endless loop: you want some changes; I show you it does not work;

wusatosi · 2024-12-06T08:27:59Z

CMakeLists.txt


-add_library(beman.inplace_vector INTERFACE)
+add_library(beman_inplace_vector INTERFACE)


This name is non conforming

Please see too bemanproject/optional26#82

ClausKlein · 2024-12-11T16:27:50Z

you will find a way to do it as you like.

ClausKlein requested review from camio, Hels15, DeveloperPaul123 and wusatosi as code owners November 24, 2024 21:34

ClausKlein marked this pull request as draft November 24, 2024 21:34

ClausKlein force-pushed the feature/install_cmake_config_package branch 2 times, most recently from 464f37b to def8c12 Compare November 27, 2024 06:46

ClausKlein commented Nov 27, 2024

View reviewed changes

ClausKlein and others added 6 commits December 6, 2024 07:56

Modernize cmake files

39d540b

Use FILE_SET HEADERS for simplify installation Set VERIFY_INTERFACE_HEADER_SETS property Prevent use of include(CTest) Prepare CPack to easy distribution Add all_verify_interface_header_sets to CI builds Prevent in-source builds Ignore cmake configure trash

Update CMakeLists.txt

d744137

Co-authored-by: David Sankel <camior@gmail.com>

Rebased and minor fixes after review

d462d55

Prepare gcov processeing

dd79c46

Add missing license header to gcovr.cfg file

9f39d9a

Install cmake config package

9a7fd7f

Add find-package-test Prevent undefined cmake values

ClausKlein force-pushed the feature/install_cmake_config_package branch from def8c12 to 9a7fd7f Compare December 6, 2024 07:33

Rebase and minor fixes

bc1b468

ClausKlein marked this pull request as ready for review December 6, 2024 07:57

wusatosi reviewed Dec 6, 2024

View reviewed changes

ClausKlein requested a review from wusatosi December 6, 2024 08:33

ClausKlein closed this Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/install cmake config package #32

Feature/install cmake config package #32

ClausKlein commented Nov 24, 2024 •

edited

Loading

ClausKlein Nov 27, 2024

wusatosi Dec 6, 2024

ClausKlein Dec 6, 2024 •

edited

Loading

ClausKlein Nov 27, 2024

wusatosi Dec 6, 2024

ClausKlein Dec 6, 2024

wusatosi Dec 6, 2024 •

edited

Loading

wusatosi Dec 6, 2024

ClausKlein Dec 6, 2024 •

edited

Loading

wusatosi Dec 6, 2024

ClausKlein Dec 6, 2024

wusatosi Dec 6, 2024

ClausKlein Dec 6, 2024 •

edited

Loading

ClausKlein commented Dec 11, 2024


		add_library(beman.inplace_vector INTERFACE)
		add_library(beman_inplace_vector INTERFACE)

Feature/install cmake config package #32

Feature/install cmake config package #32

Conversation

ClausKlein commented Nov 24, 2024 • edited Loading

Choose a reason for hiding this comment

NOTE: we need a decision about this settings: This variant is not usable!

Choose a reason for hiding this comment

ClausKlein Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

the beman naming conventions are not usable!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

the beman name conventions prevent using and installed cmake config package!

wusatosi Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClausKlein Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

Please try yourself to make it work with confirming names!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ClausKlein Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

ClausKlein commented Dec 11, 2024

ClausKlein commented Nov 24, 2024 •

edited

Loading

ClausKlein Dec 6, 2024 •

edited

Loading

the beman name conventions prevent using and installed `cmake config package`!

wusatosi Dec 6, 2024 •

edited

Loading

ClausKlein Dec 6, 2024 •

edited

Loading

ClausKlein Dec 6, 2024 •

edited

Loading