-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split build production vs testing #29
Split build production vs testing #29
Conversation
ed29cdf
to
2488662
Compare
52f43b2
to
70ed031
Compare
70ed031
to
828cb17
Compare
With optional being a template, I'm concerned that not building tests will even more easily lead to silent breaks in building the library that only show up in users of the library. Although optional is pretty simple, I wouldn't want to encourage packagers to skip tests, even by accident. It's more important that a Conan or Vcpkg build self-test because it's even more likely that something is outside of our test matrix. I do have some code from an earlier version of my scratch project that will check if the gtest project exists before enabling the code, though. Might also switch, temporarily, to pulling googletest in as a |
I'm OK with both approaches, but I would like to use an uniform approach for all libraries in Beman - CC: @camio , maybe we can add this topic to our sync agenda. Also, I propose to move this discussion in https://discourse.bemanproject.org/t/build-tests-always-implied-or-optional-task/144. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mentioned a couple minor things, but it otherwise looks good. Note that I didn't review the docker file at all.
Sorry, I added the Dockerfile by mistake. I don't want to added right now. Currently I'm using it to replicate the environment from CI, but it's not ready. TBD |
fc86a36
to
310212f
Compare
3dd2f8b
to
c1d1892
Compare
c1d1892
to
8d0a514
Compare
20ab0df
to
e72636e
Compare
e72636e
to
c57d250
Compare
952a3ba
to
a735b3c
Compare
a735b3c
to
e167523
Compare
Split build production vs testing: #28
FetchContent_Declare
instead (gtest tag = $latest official release https://github.com/google/googletest/releases/tag/v1.14.0).BUILD_TESTING
(defaultON
- build and run tests; can be set toOFF
).