🅱️ More builder updates

examples/builder/main.mjs

@@ -7,7 +7,7 @@ ctx.start()
 const builder = new RenderableBuilder()
 
 const brick = Material.createBasicTexture('../_textures/brickwall.jpg', true)
-const crate = Material.createBasicTexture('../_textures/crate.png', true)
+const crate = Material.createBasicTexture('../_textures/STARG2.png', true)
 const base = builder.newPart('pyramid-base', crate)
 const sides = builder.newPart('pyramid-side', brick)
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "gsots3d",
-  "version": "0.0.5-alpha.8",
+  "version": "0.0.5-alpha.9",
   "description": "Getting S**t On The Screen in 3D. A library for doing 3D graphics in the browser.",
   "author": "Ben Coleman",
   "license": "MIT",

src/core/context.ts

@@ -667,6 +667,8 @@ export class Context {
     this.instancesParticles.set(instance.id, instance)
     Stats.instances++
 
+    log.debug(`✨ Created particle system`)
+
     return { instance, particleSystem }
   }
 
@@ -796,10 +798,11 @@ export class Context {
   }
 
   /**
-   *
+   * Build a instance of a custom renderable from a builder and add it to the scene
+   * @param builder Builder with
    */
   createCustomInstance(builder: RenderableBuilder) {
-    const renderable = builder.buildAllParts(this.gl)
+    const renderable = builder.build(this.gl)
     const instance = new Instance(renderable)
 
     this.instances.set(instance.id, instance)

src/renderable/builder.ts

@@ -27,28 +27,28 @@ import { ModelPart } from './model.ts'
  * const renderable = builder.build(gl)
  */
 export class RenderableBuilder {
-  private builderParts: Map<string, BuilderPart>
+  public readonly parts: Map<string, BuilderPart>
   private materials: Map<string, Material>
 
   constructor() {
-    this.builderParts = new Map<string, BuilderPart>()
+    this.parts = new Map<string, BuilderPart>()
     this.materials = new Map<string, Material>()
   }
 
   /**
-   * Create and add a 'part' each part should have a unique name, and material to apply to that part
-   * Vertex mesh data is then added to the part
+   * Create and add a 'part', each part should have a unique name, and material to apply to it
+   * Vertex mesh data is then added to the part, with addQuad and addTriangle
    * @param name Name of this part, just a string can be anything
    * @param material Material to attach and apply to all surfaces in this part
    */
   newPart(name: string, material: Material): BuilderPart {
-    if (this.builderParts.has(name)) {
+    if (this.parts.has(name)) {
       throw new Error('Builder part name exists!')
     }
 
     const builderPart = new BuilderPart()
 
-    this.builderParts.set(name, builderPart)
+    this.parts.set(name, builderPart)
     this.materials.set(name, material)
 
     return builderPart
@@ -58,15 +58,15 @@ export class RenderableBuilder {
    * Called after all parts are ready, to generate a CustomRenderable
    * @param gl A WebGL2RenderingContext
    */
-  buildAllParts(gl: WebGL2RenderingContext): CustomRenderable {
+  build(gl: WebGL2RenderingContext): CustomRenderable {
     const buffers = new Map<string, twgl.BufferInfo>()
 
-    for (const [name, builderPart] of this.builderParts) {
-      buffers.set(name, builderPart.build(gl))
+    for (const [name, builderPart] of this.parts) {
+      const partBuffers = builderPart.build(gl)
+      if (!partBuffers) continue
+      buffers.set(name, partBuffers)
     }
 
-    console.log(buffers)
-
     return new CustomRenderable(buffers, this.materials)
   }
 }
@@ -158,17 +158,17 @@ export class BuilderPart {
    * @param gl A WebGL2 rendering context
    * @returns BufferInfo used by twgl
    */
-  build(gl: WebGL2RenderingContext): twgl.BufferInfo {
+  build(gl: WebGL2RenderingContext): twgl.BufferInfo | null {
     let bufferInfo: twgl.BufferInfo
     if (this._customArrayData) {
       bufferInfo = twgl.createBufferInfoFromArrays(gl, this._customArrayData)
     } else {
       if (this.vertexData.length === 0) {
-        throw new Error('No vertices added to renderable')
+        return null
       }
 
       if (this.indexData.length === 0) {
-        throw new Error('No indices added to renderable')
+        return null
       }
 
       // This is where the magic happens