This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
statusコマンドの実装 #170
Merged
statusコマンドの実装 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@だれか レビューお願いします |
takanory
approved these changes
Feb 6, 2019
src/haro/plugins/resource.py
Outdated
| show_resources(message) | ||
|
|
||
|
|
||
| @respond_to('^status\s+del\s+(\S+)$') |
There was a problem hiding this comment.
nits: (del|delete|rm|remove) にして、2番目の引数捨てるほうがいいのでは
There was a problem hiding this comment.
あ、たしかにそういう記述方法ありますね。そのほうが見やすいので変えます 👍
| if resource: | ||
| s.delete(resource) | ||
| s.commit() | ||
|
|
There was a problem hiding this comment.
操作ごとのメッセージは考えたんですが、常に最新の状態一覧を返しているのでないほうが簡潔かなーというポリシーです
| status=None, | ||
| )) | ||
| s.commit() | ||
|
|
There was a problem hiding this comment.
nits: 追加しました的なメッセージがあると親切。 show_resources に追加のメッセージとか渡せるといいかも
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
チケットURL
このレビューで確認してほしい点
レビューチェックリスト