Fix stuff #449
Open
Fix stuff #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix mmap is null error (do not emulate frame without rom present) - use device native samplerate for correct speed and eliminate resampler lag - use static 60fps since NTSC (60Hz) cpu freq is already statically declared in papu embed example: - change default keybinds to the commonly used B=Z / A=X / START=ENTER / SELECT=SHIFT setup - make canvas pixel perfect (2x size) - add example functions for changing master volume and loading and saving nvram to window.localStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
embed example:
This earlier commit 161865d didn't really fix anything, it merely moved the wrong speed issue from devices with native samplerate of 48000 to ones which have native rate of 44100. It was never correct, as the output samplerate must match the one set in
nes.opts.sampleRatebecause the frames are timed according to this samplerate.Another way would be to define the AudioContext.sampleRate in the AudioContext() ctor but this would add an unnecessary resampling step. Better to use the device native samplerate and time it to that.
Also cleaned up some functions and variables which don't exist / aren't used. Overall this codebase is in dire need of refactoring and cleanup but on the other hand it works fine (after this PR) so I guess why fix when it ain't broken.