Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SAML support #1368

Closed
6 tasks done
mikkonie opened this issue Feb 21, 2024 · 1 comment
Closed
6 tasks done

Remove SAML support #1368

mikkonie opened this issue Feb 21, 2024 · 1 comment
Assignees
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Feb 21, 2024

The SAML package we currently use will no longer work once we upgrade to Django 4.2, see #880. In the near future we plan on adding OpenIDC support, see #1367.

I asked around, and there is only one known instance of a SODAR Core based project currently using SAML. They are using an old version, in no hurry to upgrade and once they do, they'll be able to switch from SAML to OpenIDC.

Hence, there seems to be no reason to keep around SAML support. I will hence be removing it from v1.0.

If there is a specific need for SAML in the future (which is very doubtful IMHO), support can be re-implemented using a modern and maintained Django package.

Tasks

  • Remove template/view additions
  • Remove settings
  • Remove dependencies
  • Remove tests (if any)
  • Update docs to say this will be replaced by OpenIDC
  • Update major changes doc
@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement app: projectroles Issue in the projectroles app labels Feb 21, 2024
@mikkonie mikkonie added this to the v1.0.0 milestone Feb 21, 2024
@mikkonie mikkonie self-assigned this Feb 21, 2024
mikkonie added a commit that referenced this issue Mar 1, 2024
mikkonie added a commit that referenced this issue Mar 1, 2024
@mikkonie
Copy link
Collaborator Author

mikkonie commented Mar 1, 2024

Done.

@mikkonie mikkonie closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant