-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django v4.2 #880
Comments
FYI: At the time of writing, I'm holding off from merging this into dev. This is because I realized that in order to get the SODAR dev env working for Postgres v12+, I need to do bihealth/irods-docker#16, bihealth/irods-docker#17 and bihealth/irods-docker#18. Why? because I'm lazy and don't want to maintain separate docker compose dev envs for SODAR and SODAR Core :P If I get more resources working on SODAR Core v1.0 tickets before finishing the aforementioned tasks, I'll bite the bullet, merge this and set up separate dev environments for myself.. |
Done. |
Django v4.0 is out since December 2021. SODAR Core v1.0 would be the prime candidate for this dependency bump.
Need to see if there are any issues in SODAR, Varfish, Kiosc et al. potentially preventing this upgrade. Feedback is welcome from @holtgrewe, @stolpeo etc.
Update 2024-01: Django 5.0 is out since December 2023. However, 4.2 is a stable LTS release and I firmly believe we should go with that instead at this point in time.
Requires #1074 (see notes).
Dependency Issues
django-plugins-bihealth
for Django 4.2 support (see Update package for Django v4.2 compatibility django-plugins#10)drf-keyed-list-bihealth
for Django 4.2 support (see Update package for Django v4.2 compatibility drf-keyed-list#6)Switch fromRemove SAML support (see Remove SAML support #1368) (4)django-saml2-auth-ai
to a maintained SAML package (see Switch to a new SAML implementation #597)django-plugins-bihealth
dependency into a PyPI release (9)drf-keyed-list-bihealth
dependency into a PyPI release (10)Internal Issues
django.utils.translation.ugettext_lazy
imports withgettext_lazy
django.conf.urls.url
imports withdjango.urls.re_path
BaseForm.__init__()
issues inTestRoleAssignmentDeleteView
(6)RemoteSiteDeleteView
post handlingProject.save()
(7)projectroles.forms
line 700 (8)Cleanup
Notes
Django v4.x drops support for Python <3.8, which means we should too.Already done!CurrentUserFormMixin
to this view and before it simply affected nothing.'Project' instance needs to have a primary key value before this relationship can be used.
in Django 4.1. Will probably have to dosuper().save(commit=False)
first.The text was updated successfully, but these errors were encountered: