Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to /vcf REST endpoint to control whether or not VRS IDs are computed for reference alleles #72

Closed
ehclark opened this issue Jan 5, 2024 · 3 comments · Fixed by #74
Assignees
Labels
enhancement New feature or request

Comments

@ehclark
Copy link
Contributor

ehclark commented Jan 5, 2024

ga4gh/vrs-python#295 added a compute_for_ref parameter for VCF annotation. This parameter should be available as an option in the /vcf REST endpoint.

Computes VRS IDs for all REF and ALT alleles:

PUT /vcf

Computes VRS IDs for all REF and ALT alleles:

PUT /vcf?for_ref=True

Computes VRS IDs for all ALT alleles:

PUT /vcf?for_ref=False
@ehclark ehclark added the enhancement New feature or request label Jan 5, 2024
@ehclark ehclark self-assigned this Jan 5, 2024
@ehclark
Copy link
Contributor Author

ehclark commented Jan 5, 2024

@korikuzma @jsstevenson @larrybabb
The changes for this and #71 require changes in vrs-python that have not been released. Is the correct thing to do here create a 2.0.0a2 version of vrs-python? And if so, how does that happen?

@korikuzma
Copy link
Contributor

@ehclark To do this, we make a release on GitHub and that will trigger a GitHub action to make a pypi release. @larrybabb Is it okay if I go ahead and do this for @ehclark ?

@larrybabb
Copy link
Contributor

Absolutely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants