Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to the /vcf endpoint to control whether VRS IDs are generated for REF alleles #74

Merged
merged 6 commits into from
Jan 16, 2024

Conversation

ehclark
Copy link
Contributor

@ehclark ehclark commented Jan 8, 2024

Added a for_ref query parameter to the /vcf endpoint that determines whether VRS IDs are generated for REF alleles. The default value is True, which is the current behavior.

The changes also include an adjustment to error handling in the VcfRegistrar._get_vrs_object() method. The VCFAnnotator in vrs-python now includes exception handling that emits a VRS_Error INFO field if an error occurs computing VRS IDs for a VCF record. So the VcfRegistrar no longer suppresses errors and logs them. They are allowed to propagate up the stack. And if no VRS object is generated by the translator, an exception is thrown.

See also #72

@ehclark ehclark merged commit f67e0f5 into main Jan 16, 2024
5 checks passed
@ehclark ehclark deleted the issue-72 branch January 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parameter to /vcf REST endpoint to control whether or not VRS IDs are computed for reference alleles
3 participants