Add parameter to the /vcf endpoint to control whether VRS IDs are generated for REF alleles #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a
for_ref
query parameter to the/vcf
endpoint that determines whether VRS IDs are generated for REF alleles. The default value isTrue
, which is the current behavior.The changes also include an adjustment to error handling in the
VcfRegistrar._get_vrs_object()
method. TheVCFAnnotator
in vrs-python now includes exception handling that emits aVRS_Error
INFO field if an error occurs computing VRS IDs for a VCF record. So theVcfRegistrar
no longer suppresses errors and logs them. They are allowed to propagate up the stack. And if no VRS object is generated by the translator, an exception is thrown.See also #72