Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: Import trubar locally #6997

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jan 19, 2025

Issue

Fixes #6992.

Description of changes

Editable install (pip install -e, python setup.py develop) does not run trubar. This PR imports it locally to avoid the unnecessary dependency.

Add-ons already do so. We made a mistake only here.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.47%. Comparing base (f3d9e19) to head (8e44908).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6997      +/-   ##
==========================================
- Coverage   88.48%   88.47%   -0.01%     
==========================================
  Files         332      332              
  Lines       73296    73296              
==========================================
- Hits        64855    64849       -6     
- Misses       8441     8447       +6     

@janezd janezd force-pushed the dont-require-trubar branch from 78171bb to 8e44908 Compare January 19, 2025 15:32
@janezd janezd requested a review from markotoplak January 19, 2025 19:57
@markotoplak
Copy link
Member

Thanks.

Now I understand how this slipped through. I was only testing editable installs with pip install -e ., which worked properly even with old version (takes care of install dependencies separately).

This PR fixes python setup.py develop

@markotoplak markotoplak merged commit 083c53d into biolab:master Jan 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

trubar and setup.py
2 participants