Update prefix: seed --> seed.subsystem #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalikapalayoor
force-pushed
the
update_seed
branch
from
69fe641 to
50f6720
Compare
bgyori
changed the title
bgyori
reviewed
Jan 17, 2025
bgyori
reviewed
Jan 17, 2025
bgyori
reviewed
Jan 17, 2025
nalikapalayoor
force-pushed
the
update_seed
branch
from
fb94a43 to
0535955
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1365 +/- ##
==========================================
+ Coverage 42.51% 46.27% +3.75%
==========================================
Files 117 118 +1
Lines 8327 8301 -26
Branches 1963 1357 -606
==========================================
+ Hits 3540 3841 +301
+ Misses 4582 4275 -307
+ Partials 205 185 -20 ☔ View full report in Codecov by Sentry. |
|
The diff looks weird because of the change in alphabetical order between prefixes but to summarize, the changes are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the current prefixes associated with The Seed, we decided to update the name of the 'seed' prefix to be 'seed.subsystems', and have 'seed' be a synonym for it instead. This PR makes this update, and also updates the 'uri_format' for 'seed.subsystems' to be a working url, as the old one seems to be outdated.
Fixes #1339