164 checking for inconsistencies in parsers and writers methods #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…been split into write data and metadata). Read and write XML tests updated to work with the new methods.
…ts to work with the new reader and writers.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
javihern98
reviewed
Jan 10, 2025
|
|
||
|
|
||
| def write( | ||
| datasets: Sequence[STR_TYPES], |
There was a problem hiding this comment.
Change to structures, these are not datasets when we write metadata
| with open(output_path, "w", encoding="UTF-8", errors="replace") as f: | ||
| f.write(outfile) | ||
|
|
||
| return None |
There was a problem hiding this comment.
This is redundant, please remove it
There was a problem hiding this comment.
It raises a mypy error if the return None is missing
…writing and removing redundancies Signed-off-by: javier.hernandez <javier.hernandez@meaningfuldata.eu>
|
Closing as it is included in #172 |
javihern98
deleted the
164-checking-for-inconsistencies-in-parsers-and-writers-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated XML reader and writers with the new signature.
reader:
def read(infile: Union[str, Path], validate: bool = False, use_dataset_id: bool = False)writer:
def write(datasets: Sequence[PandasDataset], output_path: str = "", prettyprint: bool = True, header: Optional[Header] = Header(), dimension_at_observation: Optional[Dict[str, str]] = None)