Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO Package refactor #172
base: develop
Are you sure you want to change the base?
IO Package refactor #172
Changes from 58 commits
3664415
bdf8145
2d87af7
617aa4c
2c2cab3
ffb2a8e
01f5489
ab63f01
8b960d2
41e7a8d
b140de0
0c03933
f567c50
85076af
fe1fbb4
8afd68b
5417e73
6e9ec54
386af2f
6b6886f
b6e6200
03dd8ad
bd27711
5818c40
6a4bac7
d38ed7f
e2b2946
4eca815
183fe4d
d8fa929
4ab5896
d197d44
4be7535
a78dca6
0a79372
3b48f9e
3ea8431
1544afb
ed6303a
eb7038a
e26e1ee
2a4ceb3
c7f3d14
8341e65
85bc5ea
f6df667
53ac3e6
f78463c
a527de0
09fbb8c
af4ecc7
f84d234
a9af618
4cfcab7
2363a61
885f1af
3a18798
3cbde9f
8105528
b16b2c6
fd1c3f3
d14d5db
f8e2815
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also distinguish between Structure and Data, as we do with XML?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let me check the Standard, in any case this has no impact in the rest of the code as we have a NotImplemented
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to differentiate between SDMX_JSON_2_DATA and SDMX_JSON_2_STRUCTURE