Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations title #173

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Annotations title #173

merged 7 commits into from
Jan 16, 2025
+57 −40

Conversation

sosna
Copy link
Collaborator

@sosna sosna commented Jan 16, 2025

Fix bug affecting annotations in Fusion-JSON. The Fusion-JSON annotation class expected properties like title to be present but these are optional according to the SDMX information model.

Fix #171

javihern98
javihern98 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just a minor check is needed. It is approved in any case.

src/pysdmx/io/json/fusion/messages/code.py Show resolved Hide resolved
@sosna sosna merged commit 6c89bc1 into develop Jan 16, 2025
14 checks passed
@sosna sosna deleted the annotations_title branch January 16, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javihern98 javihern98 javihern98 approved these changes

@stratosn stratosn Awaiting requested review from stratosn

@antonio-olleros antonio-olleros Awaiting requested review from antonio-olleros

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to retrieve schemas
2 participants
@sosna @javihern98